There are so many variables to maximizing warlock DPS. I agree that this conversation is mostly just someone wanting to prove that, in a vacuum,
hit is better than
crit. However, when you start taking a lot of stuff into account like the number of warlocks your raid typically takes and then figuring out how to maximize uptime for Imp Shadow Bolt
or start thinking ahead and not assuming you'll be running every boss fight in the game with the Ony + DM
or Songflower buff
or calculating all your consumables, you realize you can't just say flatly that the "argument is over".
The only item to item comparison that makes this idea even somewhat justified is comparing t2.5 helm and Mish'undare because the starts are so close.
http://db.vanillagaming.org/?item=21337 vs.
http://db.vanillagaming.org/?item=19375 . Outside of this instance, I think this whole discussion is pretty pointless. If you really think your itemization is correct, you can prove it on raidstats.