best class to herb on?

[Lifealert]

Mage because you just farm dire maul mobs for herbs

[Xom]

+1 for Mage since you can always Port to another part of the world of that zone/region is herbed out or over-farmed.